linux-kernel - Re: [PATCH] Fix end_of_stack() fn and location of stack canary for archs using STACK

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <541C11C1.2060105@imgtec.com>
Date:	Fri, 19 Sep 2014 12:21:37 +0100
From:	James Hogan <james.hogan@...tec.com>
To:	Chuck Ebbert <cebbert.lkml@...il.com>, Helge Deller <deller@....de>
CC:	<linux-kernel@...r.kernel.org>, <linux-parisc@...r.kernel.org>,
	"Aaron Tomlin" <atomlin@...hat.com>,
	linux-metag <linux-metag@...r.kernel.org>
Subject: Re: [PATCH] Fix end_of_stack() fn and location of stack canary for
 archs using STACK_GROWSUP

Hi Chuck,

On 16/09/14 08:37, Chuck Ebbert wrote:
>  static inline unsigned long *end_of_stack(struct task_struct *p)
>  {
> +#ifdef CONFIG_STACK_GROWSUP
> +	return (unsigned long *)((unsigned long)task_thread_info(p) + THREAD_SIZE) - 1;

Nit: this line should probably be wrapped to 80 columns.

Other than that, I've tested this on metag and can confirm that it fixes
the following BUG which you would otherwise get during boot with Aaron's
patches:

BUG: failure at kernel/sched/core.c:2664/schedule_debug()!
Kernel panic - not syncing: BUG!

Tested-by: James Hogan <james.hogan@...tec.com> [metag]
Acked-by: James Hogan <james.hogan@...tec.com>

Aaron: please can you try to get this patch applied before your patch
series.

Thanks
James
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/