linux-kernel - Re: [PATCH] Fix end_of_stack() fn and location of stack canary for archs using STACK

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20140919133415.GG25400@atomlin.usersys.redhat.com>
Date:	Fri, 19 Sep 2014 14:34:15 +0100
From:	Aaron Tomlin <atomlin@...hat.com>
To:	mingo@...nel.org
Cc:	Chuck Ebbert <cebbert.lkml@...il.com>,
	Helge Deller <deller@....de>, linux-kernel@...r.kernel.org,
	linux-parisc@...r.kernel.org,
	linux-metag <linux-metag@...r.kernel.org>,
	James Hogan <james.hogan@...tec.com>
Subject: Re: [PATCH] Fix end_of_stack() fn and location of stack canary for
 archs using STACK_GROWSUP

On Fri, Sep 19, 2014 at 12:21:37PM +0100, James Hogan wrote:
> Hi Chuck,
> 
> On 16/09/14 08:37, Chuck Ebbert wrote:
> >  static inline unsigned long *end_of_stack(struct task_struct *p)
> >  {
> > +#ifdef CONFIG_STACK_GROWSUP
> > +	return (unsigned long *)((unsigned long)task_thread_info(p) + THREAD_SIZE) - 1;
> 
> Nit: this line should probably be wrapped to 80 columns.
> 
> Other than that, I've tested this on metag and can confirm that it fixes
> the following BUG which you would otherwise get during boot with Aaron's
> patches:
> 
> BUG: failure at kernel/sched/core.c:2664/schedule_debug()!
> Kernel panic - not syncing: BUG!
> 
> Tested-by: James Hogan <james.hogan@...tec.com> [metag]
> Acked-by: James Hogan <james.hogan@...tec.com>

OK.

Acked-by: Aaron Tomlin <atomlin@...hat.com>

> Aaron: please can you try to get this patch applied before your patch
> series.

Ingo,


I hope it's not too late to get this patch in (once the nit has been
addressed) for CONFIG_STACK_GROWSUP?

Regards,

-- 
Aaron Tomlin
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/