lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:	Fri, 19 Sep 2014 14:34:15 +0100
From:	Aaron Tomlin <>
Cc:	Chuck Ebbert <>,
	Helge Deller <>,,,
	linux-metag <>,
	James Hogan <>
Subject: Re: [PATCH] Fix end_of_stack() fn and location of stack canary for
 archs using STACK_GROWSUP

On Fri, Sep 19, 2014 at 12:21:37PM +0100, James Hogan wrote:
> Hi Chuck,
> On 16/09/14 08:37, Chuck Ebbert wrote:
> >  static inline unsigned long *end_of_stack(struct task_struct *p)
> >  {
> > +	return (unsigned long *)((unsigned long)task_thread_info(p) + THREAD_SIZE) - 1;
> Nit: this line should probably be wrapped to 80 columns.
> Other than that, I've tested this on metag and can confirm that it fixes
> the following BUG which you would otherwise get during boot with Aaron's
> patches:
> BUG: failure at kernel/sched/core.c:2664/schedule_debug()!
> Kernel panic - not syncing: BUG!
> Tested-by: James Hogan <> [metag]
> Acked-by: James Hogan <>


Acked-by: Aaron Tomlin <>

> Aaron: please can you try to get this patch applied before your patch
> series.


I hope it's not too late to get this patch in (once the nit has been
addressed) for CONFIG_STACK_GROWSUP?


Aaron Tomlin
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to
More majordomo info at
Please read the FAQ at

Powered by blists - more mailing lists