lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 19 Sep 2014 10:03:09 +0800 From: yaozq <yzq@...k-chips.com> To: Mark yao <mark.yao@...k-chips.com>, heiko@...ech.de, Boris BREZILLON <boris.brezillon@...e-electrons.com>, David Airlie <airlied@...il.com>, Rob Clark <robdclark@...il.com>, Rob Herring <robh+dt@...nel.org>, Pawel Moll <pawel.moll@....com>, Mark Rutland <mark.rutland@....com>, Ian Campbell <ijc+devicetree@...lion.org.uk>, Kumar Gala <galak@...eaurora.org>, Randy Dunlap <rdunlap@...radead.org>, Grant Likely <grant.likely@...aro.org>, Greg Kroah-Hartman <gregkh@...uxfoundation.org>, John Stultz <john.stultz@...aro.org>, Rom Lemarchand <romlem@...gle.com>, linux-doc@...r.kernel.org, kever.yang@...k-chips.com, dri-devel@...ts.freedesktop.org, dianders@...omium.org, xjq@...k-chips.com, zyw@...k-chips.com, cym@...k-chips.com, linux-rockchip@...ts.infradead.org, kfx@...k-chips.com, wxt@...k-chips.com, huangtao@...k-chips.com, devicetree@...r.kernel.org, yxj@...k-chips.com, marcheu@...omium.org, xxm@...k-chips.com, xw@...k-chips.com, linux-api@...r.kernel.org, linux-kernel@...r.kernel.org, cf@...k-chips.com Subject: Re: [PATCH v2 1/5] drm/rockchip: Add basic drm driver On 2014年09月18日 22:53, Daniel Vetter wrote: > On Thu, Sep 18, 2014 at 04:52:14PM +0200, Daniel Vetter wrote: >> On Thu, Sep 18, 2014 at 05:36:31PM +0800, Mark yao wrote: >>> This patch adds the basic structure of a DRM Driver for Rockchip Socs. >>> >>> Signed-off-by: Mark yao <mark.yao@...k-chips.com> >>> --- >>> Changes in v2: >>> - use the component framework to defer main drm driver probe >>> until all VOP devices have been probed. >>> - use dma-mapping API with ARM_DMA_USE_IOMMU, create dma mapping by >>> master device and each vop device can shared the drm dma mapping. >>> - use drm_crtc_init_with_planes and drm_universal_plane_init. >>> - remove unnecessary middle layers. >>> - add cursor set, move funcs to rockchip drm crtc. >>> - use vop reset at first init >>> - reference framebuffer when used and unreference when swap out vop >>> >>> +static const struct drm_crtc_funcs rockchip_crtc_funcs = { >>> + .set_config = drm_crtc_helper_set_config, >>> + .page_flip = rockchip_drm_crtc_page_flip, >>> + .destroy = rockchip_drm_crtc_destroy, >>> + .cursor_set = vop_crtc_cursor_set, >>> + .cursor_move = vop_crtc_cursor_move, >> If you expose your cursor plane as a universal you don't need to implement >> these two cursor functions at all. Actually the core never calls them, see >> drm_mode_cursor_universal. So if you want to expose cursors, please use >> universal cursor plane support (like i915). >> >> In general that's how new drivers should expose cursors since without >> universal planes support cursors will not be supported with the atomic >> ioctl. Since your cursor code just calls the relevant plane functions that >> should even simplify your driver ;-) > Actually you already initialize with cursor universal planes, so all this > code can simply be removed. > -Daniel I see, drm_mode_cursor_universal is nice, I would test and use it. -Mark -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists