linux-kernel - Re: [PATCH v8 1/4] pci:host: APM X-Gene PCIe host controller driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <541B770A.8070502@redhat.com>
Date:	Thu, 18 Sep 2014 20:21:30 -0400
From:	Jon Masters <jcm@...hat.com>
To:	Catalin Marinas <catalin.marinas@....com>,
	Tanmay Inamdar <tinamdar@....com>
CC:	Liviu Dudau <Liviu.Dudau@....com>,
	Bjorn Helgaas <bhelgaas@...gle.com>,
	Arnd Bergmann <arnd@...db.de>,
	Jason Gunthorpe <jgunthorpe@...idianresearch.com>,
	"grant.likely@...aro.org" <grant.likely@...aro.org>,
	Rob Herring <robh+dt@...nel.org>,
	Rob Landley <rob@...dley.net>,
	"linux-pci@...r.kernel.org" <linux-pci@...r.kernel.org>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>,
	"linux-doc@...r.kernel.org" <linux-doc@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"patches@....com" <patches@....com>
Subject: Re: [PATCH v8 1/4] pci:host: APM X-Gene PCIe host controller driver

On 09/17/2014 12:03 PM, Catalin Marinas wrote:

> So for arm64 currently we have some hooks in dma-mapping.c to intercept
> when a device is added to a bus. What I need to do though is check
> recursively whether the parent (bus) had the 'dma-coherent' property
> (pointed out by Jon). I think something like this would do (not tested):

We've got a patch now that I posted internally and we've tested. I've
asked Mark Salter to send it upstream (but hey, you'll probably just
want to switch the default over to recurse up the tree and then simply
add a new notifier register for pci_bus_type). For this stuff to work,
we need v10 of the APM X-Gene patches because (as I noticed earlier when
going through their code and testing on a board with an actual card -
and a modified devicetree node for the PCI root) that's the point they
add a call to setup the root of_nodes correctly via pci_scan_root_bus.
Prior to that the trivially obvious patch for dma-coherent doesn't work.
Today, there are two platform PCIe devices that do it right, plus the
latest APM rev of their driver just posted.

Jon.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/