| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Thu, 18 Sep 2014 17:21:01 -0700 From: Lee Jones <lee.jones@...aro.org> To: micky <micky_ching@...lsil.com.cn> Cc: sameo@...ux.intel.com, devel@...uxdriverproject.org, linux-kernel@...r.kernel.org, gregkh@...uxfoundation.org, rogerable@...ltek.com, wei_wang@...lsil.com.cn Subject: Re: [PATCH] mfd: rtsx: fix PM suspend for 5227 & 5249 On Thu, 18 Sep 2014, micky wrote: > On 09/18/2014 12:53 PM, Lee Jones wrote: > >On Thu, 18 Sep 2014, micky_ching@...lsil.com.cn wrote: > > > >>From: Micky Ching <micky_ching@...lsil.com.cn> > >> > >>Fix rts5227&5249 failed send buffer cmd after suspend, > >>PM_CTRL3 should reset before send any buffer cmd after suspend. > >>Otherwise, buffer cmd will failed, this will lead resume fail. > >> > >>Signed-off-by: Micky Ching <micky_ching@...lsil.com.cn> > >>--- > >> drivers/mfd/rts5227.c | 19 +++++++++++++++++++ > >> drivers/mfd/rts5249.c | 4 ++++ > >> drivers/mfd/rtsx_pcr.h | 1 + > >> include/linux/mfd/rtsx_pci.h | 12 ++++++++++++ > >> 4 files changed, 36 insertions(+) > >I think you'll find you just broke the build. > > > >What happens when you compile these as modules? > I build as modules with no warning or error, did you find anything wrong? Yes, you don't export the functions. EXPORT_SYMBOL() -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists