linux-kernel - Re: [PATCH] mmc: usdhi6rol0: Remove unnecessary header files

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Sat, 20 Sep 2014 19:51:43 +0200 (CEST)
From:	Guennadi Liakhovetski <g.liakhovetski@....de>
To:	Pramod Gurav <pramod.gurav@...rtplayin.com>
cc:	linux-kernel@...r.kernel.org,
	Guennadi Liakhovetski <g.liakhovetski+renesas@...il.com>,
	Chris Ball <chris@...ntf.net>,
	Ulf Hansson <ulf.hansson@...aro.org>, linux-mmc@...r.kernel.org
Subject: Re: [PATCH] mmc: usdhi6rol0: Remove unnecessary header files

On Sat, 20 Sep 2014, Pramod Gurav wrote:

> These headers are not required hence this change removes them from
> the driver.
> 
> Cc: Guennadi Liakhovetski <g.liakhovetski+renesas@...il.com>
> Cc: Chris Ball <chris@...ntf.net>
> Cc: Ulf Hansson <ulf.hansson@...aro.org>
> Cc: linux-mmc@...r.kernel.org
> Signed-off-by: Pramod Gurav <pramod.gurav@...rtplayin.com>

NAK. The fact, that code builds without certain headers doesn't mean, they 
aren't needed. E.g. string.h is needed for memcpy(), scatterlist.h is 
needed for struct scatterlist etc.

Thanks
Guennadi

> ---
>  drivers/mmc/host/usdhi6rol0.c | 7 -------
>  1 file changed, 7 deletions(-)
> 
> diff --git a/drivers/mmc/host/usdhi6rol0.c b/drivers/mmc/host/usdhi6rol0.c
> index f0a39eb..4094d8f 100644
> --- a/drivers/mmc/host/usdhi6rol0.c
> +++ b/drivers/mmc/host/usdhi6rol0.c
> @@ -12,21 +12,14 @@
>  #include <linux/device.h>
>  #include <linux/dma-mapping.h>
>  #include <linux/dmaengine.h>
> -#include <linux/highmem.h>
>  #include <linux/interrupt.h>
>  #include <linux/io.h>
> -#include <linux/log2.h>
>  #include <linux/mmc/host.h>
>  #include <linux/mmc/mmc.h>
> -#include <linux/mmc/sd.h>
>  #include <linux/mmc/sdio.h>
>  #include <linux/module.h>
>  #include <linux/pagemap.h>
>  #include <linux/platform_device.h>
> -#include <linux/scatterlist.h>
> -#include <linux/string.h>
> -#include <linux/time.h>
> -#include <linux/virtio.h>
>  #include <linux/workqueue.h>
>  
>  #define USDHI6_SD_CMD		0x0000
> -- 
> 1.8.3.2
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/