linux-kernel - Re: [PATCH RFC 2/2] vhost: support urgent descriptors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <541D503B.3070507@redhat.com>
Date:	Sat, 20 Sep 2014 12:00:27 +0200
From:	Paolo Bonzini <pbonzini@...hat.com>
To:	Jason Wang <jasowang@...hat.com>,
	"Michael S. Tsirkin" <mst@...hat.com>, linux-kernel@...r.kernel.org
CC:	kvm@...r.kernel.org, virtualization@...ts.linux-foundation.org
Subject: Re: [PATCH RFC 2/2] vhost: support urgent descriptors

Il 19/09/2014 09:10, Jason Wang ha scritto:
>> >  
>> > -	if (!vhost_has_feature(vq, VIRTIO_RING_F_EVENT_IDX)) {
>> > +	if (vq->urgent || !vhost_has_feature(vq, VIRTIO_RING_F_EVENT_IDX)) {
> So the urgent descriptor only work when event index was not enabled?
> This seems suboptimal, we may still want to benefit from event index
> even if urgent descriptor is used. Looks like we need return true here
> when vq->urgent is true?

Its ||, not &&.

Without event index, all descriptors are treated as urgent.

Paolo

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/