linux-kernel - Re: [PATCH V3 RESEND] SYSV: logging update

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <297345823.196267.1411207600196.open-xchange@webmail.nmp.skynet.be>
Date:	Sat, 20 Sep 2014 12:06:40 +0200 (CEST)
From:	Fabian Frederick <fabf@...net.be>
To:	Andrew Morton <akpm@...ux-foundation.org>
Cc:	Joe Perches <joe@...ches.com>, linux-kernel@...r.kernel.org,
	Christoph Hellwig <hch@...radead.org>
Subject: Re: [PATCH V3 RESEND] SYSV: logging update



> On 20 September 2014 at 01:00 Andrew Morton <akpm@...ux-foundation.org> wrote:
>
>
> On Sat, 13 Sep 2014 23:12:36 +0200 Fabian Frederick <fabf@...net.be> wrote:
>
> > -use current logging functions
> > -replace no level printk by pr_err
> > -add debug.c / sysv_err function to include sb->s_id
> > -use pr_fmt with standard KBUILD_MODNAME ": "
> > -use __builtin_return_address to display function name
> > logging format is now:
> > sysv: (sb->s_id) sysv_fill_super [sysv]: msg
>
> Is this patch tested?

Yes but looking at it again I wonder if __builtin_return_address is the best
function to use. %pf displays "sysv_fill_super [sysv]".
Maybe a trivial question but is there a way to have it simply display function
name ?

Of course I hope to have more feedback/testing to improve this patch.

Regards,
Fabian
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/