linux-kernel - Re: [PATCH 1/1] checkpatch: check for subject uniqueness in git repository.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2022098628.197398.1411209094968.open-xchange@webmail.nmp.skynet.be>
Date:	Sat, 20 Sep 2014 12:31:34 +0200 (CEST)
From:	Fabian Frederick <fabf@...net.be>
To:	Joe Perches <joe@...ches.com>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/1] checkpatch: check for subject uniqueness in git
 repository.



> On 16 September 2014 at 18:31 Joe Perches <joe@...ches.com> wrote:
>
>
> On Tue, 2014-09-16 at 18:15 +0200, Fabian Frederick wrote:
> > > On 16 September 2014 at 05:22 Joe Perches <joe@...ches.com> wrote:
> > > On Mon, 2014-09-15 at 20:43 +0200, Fabian Frederick wrote:
> > > > Adding patch subject uniqueness check in checkpatch --strict mode.
> > > > See Documentation/SubmittingPatches/globally-unique identifier.
> > >
> > > Perhaps something like this?
> []
> > > diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> []
> > > +     if ($check && $#git_commits < 1 && which("git") && -e ".git") {
> > > +             my $output = `git log --no-color --format='%H %s' 2>&1`;
> > > +             $output =~ s/^\s*//gm;
> > > +             @git_commits = split("\n", $output);
> > > +     }
>
> > Perfect ! :)
>
> Except for that _really, really_ long time to do the
> git log of all commits...
>
> Maybe the git log should be enabled only with another
> command-line option.
>
Hello Joe,

checkpatck does already execute git log in seed_camelcase_includes and
git_commit_info when .git exists
so we could add some specific option instead like --complete --verbose
--checkduplicates or something for this test ?

Regards,
Fabian
 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/