linux-kernel - Re: [PATCH 0/2] perf tool: improve error handling in perf_flag

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20140920121438.GB15481@krava.brq.redhat.com>
Date:	Sat, 20 Sep 2014 14:14:38 +0200
From:	Jiri Olsa <jolsa@...hat.com>
To:	Yann Droneaud <ydroneaud@...eya.com>
Cc:	linux-kernel@...r.kernel.org,
	Adrian Hunter <adrian.hunter@...el.com>,
	David Ahern <dsahern@...il.com>,
	Frederic Weisbecker <fweisbec@...il.com>,
	Jiri Olsa <jolsa@...nel.org>,
	Namhyung Kim <namhyung@...il.com>,
	Paul Mackerras <paulus@...ba.org>,
	Peter Zijlstra <peterz@...radead.org>,
	Stephane Eranian <eranian@...gle.com>,
	William Cohen <wcohen@...hat.com>
Subject: Re: [PATCH 0/2] perf tool: improve error handling in
 perf_flag_probe()

On Sat, Sep 13, 2014 at 10:46:22AM +0200, Yann Droneaud wrote:
> Hi,
> 
> Following the EBUSY errors reported by Jiri Olsa [1], I've tryed to
> improve a bit the way perf_flag_probe() handle errors.
> 
> In case EBUSY is returned by perf_event_open(), testing the function
> again without PERF_FLAG_FD_CLOEXEC is meaningless: EBUSY is not
> related to close-on-exec flag, so there's nothing to confirm.
> 
> For other errors, not yet handled by perf_flag_probe(), it's
> pointless to report a second error message for the same error code:
> the second check should not print an error if the error is the same
> as the one return for the first check.
> 
> [1] http://lkml.kernel.org/r/1406908014-8312-1-git-send-email-jolsa@kernel.org
> 
> Yann Droneaud (2):
>   perf tools: shortcut PERF_FLAG_FD_CLOEXEC probing in case of EBUSY
>     error
>   perf tools: report PERF_FLAG_FD_CLOEXEC probing error once

seems good to me, for the patchset:
Acked-by: Jiri Olsa <jolsa@...nel.org>

thanks,
jirka
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/