lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 22 Sep 2014 15:16:40 +0200 From: Uwe Kleine-König <u.kleine-koenig@...gutronix.de> To: Wolfram Sang <wsa@...-dreams.de> Cc: Anders Berg <anders.berg@...gotech.com>, devicetree@...r.kernel.org, linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org, linux-i2c@...r.kernel.org Subject: Re: [PATCH] i2c: axxia: Add I2C driver for AXM55xx On Sat, Sep 20, 2014 at 02:12:43PM +0200, Wolfram Sang wrote: > Hi, > > thanks for the submission. > > On Mon, Aug 25, 2014 at 01:51:22PM +0200, Anders Berg wrote: > > Add I2C bus driver for the controller found in the LSI Axxia family SoCs. The > > driver implements 10-bit addressing and SMBus transfer modes via emulation > > (including SMBus block data read). > > > > Signed-off-by: Anders Berg <anders.berg@...gotech.com> > > Looks pretty good already. Still, some comments: > > > +config I2C_AXXIA > > + tristate "Axxia I2C controller" > > + depends on ARCH_AXXIA > > + help > > + Say yes if you want to support the I2C bus on Axxia platforms. > > + > > + If you don't know, say Y. > > I'd say skip this sentence and consider 'default y' if it is really > needed on this platform. Still better: depends on ARCH_AXXIA || COMPILE_TEST default ARCH_AXXIA Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | http://www.pengutronix.de/ | -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists