linux-kernel - Re: [Xen-devel] [PATCH 3/3 v2] xen/xenbus: Improve failure processing code for __xenbus_switch

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 22 Sep 2014 23:51:08 +0800
From:	Chen Gang <gang.chen.5i5j@...il.com>
To:	David Vrabel <david.vrabel@...rix.com>
CC:	konrad.wilk@...cle.com, boris.ostrovsky@...cle.com,
	stefano.stabellini@...citrix.com, mukesh.rathor@...cle.com,
	xen-devel@...ts.xenproject.org,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [Xen-devel] [PATCH 3/3 v2] xen/xenbus: Improve failure processing
 code for __xenbus_switch_state()

On 09/22/2014 11:04 PM, David Vrabel wrote:
> On 18/09/14 15:01, Chen Gang wrote:
>> When failure occurs, need return failure code instead of 0, or some of
>> indirect upper callers may misunderstand.
>>
>> e.g. in "block/xen-blkback/xenbus.c":
>>
>>     connect() -> xenbus_switch_state() -> __xenbus_switch_state().
> 
> Can you make xenbus_switch_state() void?  The callers don't need to do
> any error handling.
> 

After "grep rn xenbus_switch_state *" under "drivers/", it is not one
place to check the return value of xenbus_switch_state(), and also it
is export to outside for individual modules.

So we need change many subsystems for it, and also need face the rick
for incompatible with the old individual modules which source code are
not in upstream.

And are you sure the caller need not notice about it, when it really
fails? (for me, I guess they need notice about it)

Thanks.
-- 
Chen Gang

Open share and attitude like air water and life which God blessed
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/