linux-kernel - Re: [Regression] cifs: sanity check length of data to send before sending

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 23 Sep 2014 18:49:26 -0400
From:	Jeff Layton <jlayton@...ba.org>
To:	Joseph Salisbury <joseph.salisbury@...onical.com>
Cc:	sfrench@...ba.org, linux-cifs@...r.kernel.org,
	samba-technical@...ts.samba.org,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [Regression]  cifs: sanity check length of data to send before
 sending

On Tue, 23 Sep 2014 15:09:23 -0400
Joseph Salisbury <joseph.salisbury@...onical.com> wrote:

> Hi Jeff,
> 
> A kernel bug report was opened against Ubuntu [0].  It was found that
> reverting the following commit resolved this bug:
> 
> 
> commit a26054d184763969a411e3939fe243516715ff59
> Author: Jeff Layton <jlayton@...hat.com>
> Date:   Fri Feb 14 07:21:00 2014 -0500
> 
>     cifs: sanity check length of data to send before sending
> 
>       
> The regression was introduced as of v3.14-rc7.
> 
> It appears the patch may be doing what it is supposed to, since the
> send_length != smb_buf_length:
> send_length=72
> and
> smb_buf_length=2164260932
> 
> However, without this check and WARN/return of -EIO the samba
> connections still work correctly.
> 
> I was hoping to get your feedback, since you are the patch author.  Do
> you think gathering any additional data will help diagnose this issue,
> or would it be best to submit a revert request?
>     
> Thanks,
>     
> Joe
> 
> [0] http://pad.lv/1372482
> 

(I'm no longer with Red Hat, so the jlayton@...hat.com address won't
reach me any longer...)

It looks like you probably just need to merge
dca1c8d17a2feae056f9e334ea75a462ae4cb52a into your kernel as well.

Cheers,
-- 
Jeff Layton <jlayton@...ba.org>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/