linux-kernel - [Regression] cifs: sanity check length of data to send before sending

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <5421C563.8070304@canonical.com>
Date:	Tue, 23 Sep 2014 15:09:23 -0400
From:	Joseph Salisbury <joseph.salisbury@...onical.com>
To:	jlayton@...hat.com
CC:	sfrench@...ba.org, linux-cifs@...r.kernel.org,
	samba-technical@...ts.samba.org,
	LKML <linux-kernel@...r.kernel.org>
Subject: [Regression]  cifs: sanity check length of data to send before sending

Hi Jeff,

A kernel bug report was opened against Ubuntu [0].  It was found that
reverting the following commit resolved this bug:

commit a26054d184763969a411e3939fe243516715ff59
Author: Jeff Layton <jlayton@...hat.com>
Date:   Fri Feb 14 07:21:00 2014 -0500

    cifs: sanity check length of data to send before sending

The regression was introduced as of v3.14-rc7.

It appears the patch may be doing what it is supposed to, since the
send_length != smb_buf_length:
send_length=72
and
smb_buf_length=2164260932

However, without this check and WARN/return of -EIO the samba
connections still work correctly.

I was hoping to get your feedback, since you are the patch author.  Do
you think gathering any additional data will help diagnose this issue,
or would it be best to submit a revert request?

Thanks,

Joe

[0] http://pad.lv/1372482

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/