linux-kernel - Re: [PATCH v3] serial: 8250: Add Quark X1000 to 8250

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20140923075817.GA18814@xps8300>
Date:	Tue, 23 Sep 2014 10:58:17 +0300
From:	Heikki Krogerus <heikki.krogerus@...ux.intel.com>
To:	Bryan O'Donoghue <pure.logic@...us-software.ie>
Cc:	gregkh@...uxfoundation.org, jslaby@...e.cz,
	andriy.shevchenko@...ux.intel.com, kean.ho.chew@...el.com,
	linux-kernel@...r.kernel.org, linux-serial@...r.kernel.org
Subject: Re: [PATCH v3] serial: 8250: Add Quark X1000 to 8250_pci.c

On Tue, Sep 23, 2014 at 01:21:11AM +0100, Bryan O'Donoghue wrote:
> Quark X1000 contains two designware derived 8250 serial ports.
> Each port has a unique PCI configuration space consisting of
> BAR0:UART BAR1:DMA respectively.
> 
> Unlike the standard 8250 the register width is 32 bits for RHR,IER etc
> The Quark UART has a fundamental clock @ 44.2368 MHz allowing for a
> bitrate of up to about 2.76 megabits per second.
> 
> This patch enables standard 8250 mode
> 
> Signed-off-by: Bryan O'Donoghue <pure.logic@...us-software.ie>

Looks good to me. FWIW..

Reviewed-by: Heikki Krogerus <heikki.krogerus@...ux.intel.com>

Thanks,

-- 
heikki
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/