linux-kernel - Re: [PATCH] tty/serial: fix config dependencies for samsung serial

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5903767.VzDJhUfQDI@wuerfel>
Date:	Tue, 23 Sep 2014 10:07:31 +0200
From:	Arnd Bergmann <arnd@...db.de>
To:	linux-arm-kernel@...ts.infradead.org
Cc:	Abhilash Kesavan <kesavan.abhilash@...il.com>,
	"linux-samsung-soc@...r.kernel.org" 
	<linux-samsung-soc@...r.kernel.org>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	linux-serial@...r.kernel.org,
	Pankaj Dubey <pankaj.dubey@...sung.com>,
	Naveen Krishna Ch <naveenkrishna.ch@...il.com>,
	Naveen Krishna Chatradhi <ch.naveen@...sung.com>
Subject: Re: [PATCH] tty/serial: fix config dependencies for samsung serial

On Tuesday 23 September 2014 12:34:26 Abhilash Kesavan wrote:
> >>
> >> The SERIAL_SAMSUNG_UARTS_4 and SERIAL_SAMSUNG_UARTS config options are
> >> meaningful only if SERIAL_SAMSUNG is enabled. Hence the dependency
> >> rules were changed. I will repost this patch with better description.
> >
> > My point is that the options are used by both the uart driver and
> > the platform code, e.g. for the purpose of PM debugging which can
> > be enabled even when the serial-samsung driver is turned off.
> 
> I looked through the code and could find two references to these
> symbols in the platform-specific code: arch/arm/plat-samsung/init.c
> and arch/arm/mach-s3c64xx/irq-pm.c. The first one is being used to
> initialize the uart platform device in non-dt way while the second one
> saves and restores the uart irq masks for all channels across a
> suspend/resume cycle. Also, the save/restore will get bypassed in case
> CONFIG_SERIAL_SAMSUNG_UARTS is not defined. It does not look like
> either of these cases would cause any issue with the current patch,
> can you please help me understand the problem ?

It's possible that it works fine now, I just pointed out that we
had bugs in this area in the past, so it would be good if you can
add to the changelog a statement that you have checked that the
new patch does not cause problems here.

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/