linux-kernel - Re: [PATCH v3 2/3] sched: add macros to define bitops for task atomic flags

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAGXu5jLjAtHUZsLW0S4SPaKtx__P-fgeCQqD6naKYVtJ_9b9Eg@mail.gmail.com>
Date:	Tue, 23 Sep 2014 09:58:23 -0700
From:	Kees Cook <keescook@...omium.org>
To:	Peter Zijlstra <peterz@...radead.org>
Cc:	Zefan Li <lizefan@...wei.com>, Tejun Heo <tj@...nel.org>,
	Ingo Molnar <mingo@...nel.org>,
	Miao Xie <miaox@...fujitsu.com>,
	Tetsuo Handa <penguin-kernel@...ove.sakura.ne.jp>,
	LKML <linux-kernel@...r.kernel.org>,
	Cgroups <cgroups@...r.kernel.org>
Subject: Re: [PATCH v3 2/3] sched: add macros to define bitops for task atomic flags

On Tue, Sep 23, 2014 at 3:01 AM, Peter Zijlstra <peterz@...radead.org> wrote:
> On Tue, Sep 23, 2014 at 03:44:59PM +0800, Zefan Li wrote:
>> This will simplify code when we add new flags.
>>
>> v3:
>> - Kees pointed out that no_new_privs should never be cleared, so we
>> shouldn't define task_clear_no_new_privs(). we define 3 macros instead
>> of a single one.

Thanks! This looks good to me.

>>
>> v2:
>> - updated scripts/tags.sh, suggested by Peter.
>>
>> Cc: Peter Zijlstra <peterz@...radead.org>
>> Cc: Ingo Molnar <mingo@...nel.org>
>> Cc: Miao Xie <miaox@...fujitsu.com>
>> Cc: Kees Cook <keescook@...omium.org>
>> Cc: Tetsuo Handa <penguin-kernel@...ove.SAKURA.ne.jp>
>> Signed-off-by: Zefan Li <lizefan@...wei.com>
>
> Acked-by: Peter Zijlstra (Intel) <peterz@...radead.org>

Acked-by: Kees Cook <keescook@...omium.org>

-Kees

-- 
Kees Cook
Chrome OS Security
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/