linux-kernel - Re: [PATCH] kbuild, LLVMLinux: Fix asm-offset generation to work with clang

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 24 Sep 2014 11:27:06 -0700
From:	Behan Webster <behanw@...verseincode.com>
To:	Arnd Bergmann <arnd@...db.de>
CC:	mq@...e.cz, linux-kernel@...r.kernel.org,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Ard Biesheuvel <ard.biesheuvel@...aro.org>,
	"H. Peter Anvin" <hpa@...ux.intel.com>,
	Tom Gundersen <teg@...m.no>,
	Masahiro Yamada <yamada.m@...panasonic.com>,
	fengguang.wu@...el.com
Subject: Re: [PATCH] kbuild, LLVMLinux: Fix asm-offset generation to work
 with clang

On 09/24/14 03:37, Arnd Bergmann wrote:
> On Tuesday 23 September 2014 12:25:31 behanw@...verseincode.com wrote:
>>   #define DEFINE(sym, val) \
>> -        asm volatile("\n->" #sym " %0 " #val : : "i" (val))
>> +       asm volatile("\n@->" #sym " %0 " #val : : "i" (val))
> Isn't the '@' character to start a comment architecture specific?
I had worried about that as well (as we discussed at LCU), but with the 
limited testing I tried this with it seemed to indicate that gas was 
smart enough to handle it in most cases. However the kbuild test robot 
indicates that this patch breaks MIPS. So indeed your concern is justified.

Gotta love the kbuild test robot. Thank you Fengguang Wu!

> If this makes it work on ARM, what about other architectures?
For now, I think I need to try something else.

Thanks,

Behan

-- 
Behan Webster
behanw@...verseincode.com

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/