linux-kernel - Re: [PATCH] kbuild, LLVMLinux: Fix asm-offset generation to work with clang

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3907075.FRP0QfugZW@wuerfel>
Date:	Wed, 24 Sep 2014 12:37:03 +0200
From:	Arnd Bergmann <arnd@...db.de>
To:	behanw@...verseincode.com
Cc:	mq@...e.cz, linux-kernel@...r.kernel.org,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Ard Biesheuvel <ard.biesheuvel@...aro.org>,
	"H. Peter Anvin" <hpa@...ux.intel.com>,
	Tom Gundersen <teg@...m.no>,
	Masahiro Yamada <yamada.m@...panasonic.com>
Subject: Re: [PATCH] kbuild, LLVMLinux: Fix asm-offset generation to work with clang

On Tuesday 23 September 2014 12:25:31 behanw@...verseincode.com wrote:
> 
>  #define DEFINE(sym, val) \
> -        asm volatile("\n->" #sym " %0 " #val : : "i" (val))
> +       asm volatile("\n@->" #sym " %0 " #val : : "i" (val))

Isn't the '@' character to start a comment architecture specific?

If this makes it work on ARM, what about other architectures?

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/