linux-kernel - Re: [PATCH v4 02/10] block: introduce blk_init

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140924101850.GA19078@lst.de>
Date:	Wed, 24 Sep 2014 12:18:50 +0200
From:	Christoph Hellwig <hch@....de>
To:	Ming Lei <ming.lei@...onical.com>
Cc:	Jens Axboe <axboe@...nel.dk>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4 02/10] block: introduce blk_init_flush and its pair

On Mon, Sep 15, 2014 at 09:11:06PM +0800, Ming Lei wrote:
> These two temporary functions are introduced for holding flush
> initialization and de-initialization, so that we can
> introduce 'flush queue' easier in the following patch. And
> once 'flush queue' and its allocation/free functions are ready,
> they will be removed for sake of code readability.

Shouldn't we just do the mq work in this helper as well?  blk_mq_init_flush
does exactly the same work, plus initializing a lock, which is harmless
for the !mq case as well.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/