linux-kernel - Re: [PATCH v2] pinctrl: qcom: use restart_notifier mechanism for ps

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACRpkdauNieUTSAR=PGsvrXOrPNsBgyCPC9Ot=ZDXctfSdEp8w@mail.gmail.com>
Date:	Thu, 25 Sep 2014 09:41:02 +0200
From:	Linus Walleij <linus.walleij@...aro.org>
To:	Josh Cartwright <joshc@...eaurora.org>,
	Bjorn Andersson <Bjorn.Andersson@...ymobile.com>
Cc:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Pramod Gurav <pramod.gurav@...rtplayin.com>,
	Guenter Roeck <linux@...ck-us.net>
Subject: Re: [PATCH v2] pinctrl: qcom: use restart_notifier mechanism for ps_hold

On Tue, Sep 23, 2014 at 10:59 PM, Josh Cartwright <joshc@...eaurora.org> wrote:

> By converting to the restart_notifier mechanism for restart, we allow
> for other mechanisms, like the watchdog, to be used for restart in the
> case where PS_HOLD has failed to reset the chip.
>
> Since this mechanism may be one of several mechanisms registered, change
> the post-ps_hold write timeout to be a more reasonable 1 second instead
> of 10 seconds.
>
> Choose priority 128, as according to documentation, this mechanism "is
> sufficient to restart the entire system".
>
> Cc: Pramod Gurav <pramod.gurav@...rtplayin.com>
> Cc: Guenter Roeck <linux@...ck-us.net>
> Tested-by: Pramod Gurav <pramod.gurav@...rtplayin.com>
> Signed-off-by: Josh Cartwright <joshc@...eaurora.org>
> ---
>
> Changes since v1:
>   - Simplified conditional notifier block registration
>   - Reduced wait time to 1s, which I've found to be sufficient on an IFC6410
>     board.

Björn, are you OK with this patch?

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/