linux-kernel - Re: [PATCH] pwm: atmel-pwm: fix calculation of prescale value

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20140925074947.GA11843@ulmo>
Date:	Thu, 25 Sep 2014 09:49:48 +0200
From:	Thierry Reding <thierry.reding@...il.com>
To:	Nikolaus Voss <n.voss@...nmann-emt.de>
Cc:	Bo Shen <voice.shen@...el.com>,
	Nicolas Ferre <nicolas.ferre@...el.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] pwm: atmel-pwm: fix calculation of prescale value

On Thu, Sep 25, 2014 at 09:47:34AM +0200, Nikolaus Voss wrote:
> On Thu, 25 Sep 2014, Thierry Reding wrote:
[...]
> >>-		}
> >>+		div >>= 1;
> >>+		++pres;
> >
> >Unless you really need the prefix increment behaviour (you don't in this
> >case) I prefer using the postfix operator because it is slightly more
> >idiomatic.
> 
> ok (as I mostly do C++ programming, I prefer the prefix as it is usually
> more efficient for user-defined types).

It is? That's intriguing...

Thierry

Content of type "application/pgp-signature" skipped