linux-kernel - Re: [PATCH] pwm: atmel-pwm: fix calculation of prescale value

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.10.1409250934090.38376@fox.voss.local>
Date:	Thu, 25 Sep 2014 09:47:34 +0200 (CEST)
From:	Nikolaus Voss <n.voss@...nmann-emt.de>
To:	Thierry Reding <thierry.reding@...il.com>
cc:	Bo Shen <voice.shen@...el.com>,
	Nicolas Ferre <nicolas.ferre@...el.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] pwm: atmel-pwm: fix calculation of prescale value

Hi Thierry,

On Thu, 25 Sep 2014, Thierry Reding wrote:
> Please Cc the linux-pwm@...r.kernel.org mailing list for PWM-related
> patches in the future.

ok, I ran get_maintainer.pl on an old kernel...

> Also a couple more comments:
>
> In the patch description: "pwm frequency" should be "PWM frequency".

ok.

>> +	div = (unsigned long long)clk_get_rate(atmel_pwm->clk) * period_ns;
>> +	do_div(div, (int)1e9);
>
> 1e9 should be NSEC_PER_SEC.
>

>> -		}
>> +		div >>= 1;
>> +		++pres;
>
> Unless you really need the prefix increment behaviour (you don't in this
> case) I prefer using the postfix operator because it is slightly more
> idiomatic.

ok (as I mostly do C++ programming, I prefer the prefix as it is usually
more efficient for user-defined types).

> No need for you to respin the patch, I've fixed up the above when
> applying.

Thanks!

Niko

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/