linux-kernel - [RFC PATCH V3 1/3] PM/CPU: Parallel enalbing nonboot cpus with resume devices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 25 Sep 2014 16:32:03 +0800
From:	Lan Tianyu <tianyu.lan@...el.com>
To:	peterz@...radead.org, mingo@...nel.org, rafael.j.wysocki@...el.com,
	toshi.kani@...com, akpm@...ux-foundation.org, tianyu.lan@...el.com,
	ktkhai@...allels.com, fabf@...net.be, laijs@...fujitsu.com,
	srivatsa.bhat@...ux.vnet.ibm.com, srivatsa@....edu,
	ego@...ux.vnet.ibm.com, viresh.kumar@...aro.org
Cc:	todd.e.brandt@...ux.intel.com, tipbot@...or.com,
	wangyun@...ux.vnet.ibm.com, linux-kernel@...r.kernel.org,
	linux-pm@...r.kernel.org
Subject: [RFC PATCH V3 1/3] PM/CPU: Parallel enalbing nonboot cpus with resume devices

In the current world, all nonboot cpus are enalbed serially during system
resume. System resume sequence is that boot cpu enables nonboot cpu one by
one and then resume devices. Before resuming devices, there are few tasks
assigned to nonboot cpus after they are brought up. This waste cpu usage.

To accelerate S3, this patchset is to allow boot cpu to go forward to
resume devices after bringing up one nonboot cpu and starting a thread.
The thread will be in charge of bringing up other frozen cpus. The thread
will be scheduled to the first online cpu to run . This makes enabling
cpu2~x parallel with resuming devices.

Signed-off-by: Lan Tianyu <tianyu.lan@...el.com>
---
 kernel/cpu.c | 67 ++++++++++++++++++++++++++++++++++++++++++++++++++----------
 1 file changed, 56 insertions(+), 11 deletions(-)

diff --git a/kernel/cpu.c b/kernel/cpu.c
index 356450f..24c4889 100644
--- a/kernel/cpu.c
+++ b/kernel/cpu.c
@@ -572,8 +572,41 @@ void __weak arch_enable_nonboot_cpus_end(void)
 {
 }
 
+static int _cpu_up_for_pm(int cpu)
+{
+	int error;
+
+	trace_suspend_resume(TPS("CPU_ON"), cpu, true);
+	error = _cpu_up(cpu, 1);
+	trace_suspend_resume(TPS("CPU_ON"), cpu, false);
+	if (error) {
+		pr_warn("Error taking CPU%d up: %d\n", cpu, error);
+		return error;
+	}
+
+	pr_info("CPU%d is up\n", cpu);
+	return 0;
+}
+
+static int async_enable_nonboot_cpus(void *data)
+{
+	int cpu;
+
+	arch_enable_nonboot_cpus_begin();
+
+	for_each_cpu(cpu, frozen_cpus) {
+		_cpu_up_for_pm(cpu);
+	}
+
+	arch_enable_nonboot_cpus_end();
+	cpumask_clear(frozen_cpus);
+	cpu_maps_update_done();
+	return 0;
+}
+
 void __ref enable_nonboot_cpus(void)
 {
+	struct task_struct *tsk;
 	int cpu, error;
 
 	/* Allow everyone to use the CPU hotplug again */
@@ -584,21 +617,33 @@ void __ref enable_nonboot_cpus(void)
 
 	pr_info("Enabling non-boot CPUs ...\n");
 
-	arch_enable_nonboot_cpus_begin();
+	cpu = cpumask_first(frozen_cpus);
+	cpumask_clear_cpu(cpu, frozen_cpus);
+	error = _cpu_up_for_pm(cpu);
+	if (error) {
+		pr_err("Failed to bring up first non-boot cpu.\n");
+		goto fail;
+	}
 
-	for_each_cpu(cpu, frozen_cpus) {
-		trace_suspend_resume(TPS("CPU_ON"), cpu, true);
-		error = _cpu_up(cpu, 1);
-		trace_suspend_resume(TPS("CPU_ON"), cpu, false);
-		if (!error) {
-			pr_info("CPU%d is up\n", cpu);
-			continue;
-		}
-		pr_warn("Error taking CPU%d up: %d\n", cpu, error);
+	tsk = kthread_run(async_enable_nonboot_cpus,
+			NULL, "async-enable-nonboot-cpus");
+	if (IS_ERR(tsk)) {
+		pr_err("Failed to create async enable nonboot cpus thread.\n");
+		goto fail;
 	}
+	return;
 
+fail:
+	/*
+	 * If fail to bring up the first frozen cpu or
+	 * start async thread, enable these rest frozen cpus
+	 * on the boot cpu.
+	 */
+	arch_enable_nonboot_cpus_begin();
+	for_each_cpu(cpu, frozen_cpus) {
+		_cpu_up_for_pm(cpu);
+	}
 	arch_enable_nonboot_cpus_end();
-
 	cpumask_clear(frozen_cpus);
 out:
 	cpu_maps_update_done();
-- 
1.8.4.rc0.1.g8f6a3e5.dirty

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/