linux-kernel - Re: [PATCH v14 net-next 10/11] bpf: verifier (add verifier core)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20140926.004024.1179261758092351350.davem@davemloft.net>
Date:	Fri, 26 Sep 2014 00:40:24 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	ast@...mgrid.com
Cc:	mingo@...nel.org, torvalds@...ux-foundation.org,
	luto@...capital.net, dborkman@...hat.com,
	hannes@...essinduktion.org, chema@...gle.com, edumazet@...gle.com,
	a.p.zijlstra@...llo.nl, pablo@...filter.org, hpa@...or.com,
	akpm@...ux-foundation.org, keescook@...omium.org,
	linux-api@...r.kernel.org, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v14 net-next 10/11] bpf: verifier (add verifier core)

From: Alexei Starovoitov <ast@...mgrid.com>
Date: Sun, 21 Sep 2014 17:06:50 -0700

> +#define _(OP) ({ int ret = (OP); if (ret < 0) return ret; })

Please do not hide program control flow inside of a macro.

Thank you.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/