linux-kernel - Re: [PATCH] dma: imx-sdma: fix another incorrect _

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Sun, 28 Sep 2014 21:30:41 +0530
From:	Vinod Koul <vinod.koul@...el.com>
To:	Arnd Bergmann <arnd@...db.de>
Cc:	linux-arm-kernel@...ts.infradead.org,
	Mark Brown <broonie@...aro.org>,
	Dan Williams <dan.j.williams@...el.com>,
	dmaengine@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] dma: imx-sdma: fix another incorrect __init annotation

On Fri, Sep 26, 2014 at 11:24:00PM +0200, Arnd Bergmann wrote:
> In e34b731faa7d1 ("dma: imx-sdma: Remove spurious __init annotation on
> sdma_probe()"), Mark found an extraneous __init label and fixed it.
> 
> However, he missed another one, because now we get this other warning:
> 
> WARNING: drivers/dma/imx-sdma.o(.text+0x3bb4): Section mismatch in reference from the function sdma_probe() to the function .init.text:sdma_get_firmware()
> The function sdma_probe() references
> the function __init sdma_get_firmware().
> 
> Same reasoning as the last time, the function may get called at
> runtime, so it can't be __init.
> 
Applied, thanks

-- 
~Vinod

> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> 
> diff --git a/drivers/dma/imx-sdma.c b/drivers/dma/imx-sdma.c
> index 52ce1d21154c..88afc48c2ca7 100644
> --- a/drivers/dma/imx-sdma.c
> +++ b/drivers/dma/imx-sdma.c
> @@ -1334,7 +1334,7 @@ err_firmware:
>  	release_firmware(fw);
>  }
>  
> -static int __init sdma_get_firmware(struct sdma_engine *sdma,
> +static int sdma_get_firmware(struct sdma_engine *sdma,
>  		const char *fw_name)
>  {
>  	int ret;
> 
> --
> To unsubscribe from this list: send the line "unsubscribe dmaengine" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

-- 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/