linux-kernel - Re: [PATCH 1/2] DT: add binding for mxs regulator

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140928102202.GM27755@sirena.org.uk>
Date:	Sun, 28 Sep 2014 11:22:02 +0100
From:	Mark Brown <broonie@...nel.org>
To:	Stefan Wahren <stefan.wahren@...e.com>
Cc:	lgirdwood@...il.com, shawn.guo@...aro.org, robh+dt@...nel.org,
	pawel.moll@....com, mark.rutland@....com,
	ijc+devicetree@...lion.org.uk, galak@...eaurora.org,
	festevam@...il.com, linux-kernel@...r.kernel.org,
	devicetree@...r.kernel.org, kernel@...gutronix.de
Subject: Re: [PATCH 1/2] DT: add binding for mxs regulator

On Sat, Sep 27, 2014 at 12:59:47AM +0000, Stefan Wahren wrote:
> This patch adds the Device tree bindings for the Freescale MXS
> on-chip regulators.

Use subject lines matching the style for the subsystem.

> +Required regulator properties:
> +- compatible: Must be "fsl,mxs-regulator"
> +- reg: Absolute physical address of the register set for the regulator
> +
> +Any regulator property defined as part of the core regulator
> +binding, defined in regulator.txt, can also be used.

While this should be using compatibles to identify which regulator is
being supported note that the binding doesn't document the fact that the
code makes regulator-name mandatory or what values are required.

Download attachment "signature.asc" of type "application/pgp-signature" (474 bytes)