linux-kernel - Re: [PATCH v5 02/10] net: pxa168

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20140929.160436.1932620234954504510.davem@davemloft.net>
Date:	Mon, 29 Sep 2014 16:04:36 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	antoine.tenart@...e-electrons.com
Cc:	sebastian.hesselbarth@...il.com,
	alexandre.belloni@...e-electrons.com,
	thomas.petazzoni@...e-electrons.com, zmxu@...vell.com,
	jszhang@...vell.com, netdev@...r.kernel.org,
	linux-arm-kernel@...ts.infradead.org, devicetree@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v5 02/10] net: pxa168_eth: add device tree support

From: Antoine Tenart <antoine.tenart@...e-electrons.com>
Date: Fri, 26 Sep 2014 16:33:48 +0200

> @@ -1603,6 +1620,12 @@ static int pxa168_eth_suspend(struct platform_device *pdev, pm_message_t state)
>  #define pxa168_eth_suspend NULL
>  #endif
>  
> +static const struct of_device_id pxa168_eth_of_match[] = {
> +	{ .compatible = "marvell,pxa168-eth" },
> +	{ },
> +};
> +MODULE_DEVICE_TABLE(of, pxa168_eth_of_match)
> +
>  static struct platform_driver pxa168_eth_driver = {

You didn't even compile test this change with module support enabled.

drivers/net/ethernet/marvell/pxa168_eth.c:1670:1: error: expected ‘,’ or ‘;’ before ‘static’

MODULE_DEVICE_TABLE() must be completed with a trailing ';'