linux-kernel - Re: [PATCH 0/5] ARM: move #include <asm/cp15.h> into cacheflush.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20140930100355.GM5182@n2100.arm.linux.org.uk>
Date:	Tue, 30 Sep 2014 11:03:55 +0100
From:	Russell King - ARM Linux <linux@....linux.org.uk>
To:	Nicolas Pitre <nicolas.pitre@...aro.org>
Cc:	Brian Norris <computersforpeace@...il.com>,
	linux-arm-kernel@...ts.infradead.org,
	Linux Kernel <linux-kernel@...r.kernel.org>,
	Jason Cooper <jason@...edaemon.net>,
	Florian Fainelli <f.fainelli@...il.com>,
	Andrew Lunn <andrew@...n.ch>,
	Gregory Clement <gregory.clement@...e-electrons.com>,
	Sebastian Hesselbarth <sebastian.hesselbarth@...il.com>,
	Heiko Stuebner <heiko@...ech.de>,
	linux-rockchip@...ts.infradead.org,
	Marc Carino <marc.ceeeee@...il.com>
Subject: Re: [PATCH 0/5] ARM: move #include <asm/cp15.h> into cacheflush.h

On Tue, Sep 30, 2014 at 12:30:06AM -0400, Nicolas Pitre wrote:
> On Mon, 29 Sep 2014, Brian Norris wrote:
> 
> > There are several places where an explicit include of <asm/cp15.h> is needed
> > just because cacheflush.h uses one of its macros in v7_exit_coherency_flush().
> > Let's put the include in the proper header.
> > 
> > These obviously have some dependencies, so I'd focus on:
> >   (1) Is patch 1 acceptable? If so, then:
> 
> Well, I'm wondering if it is really a gain to force a dependency for 
> cp15.h on every user of cacheflush.h just because of the seldomly used 
> v7_exit_coherency_flush(). But I don't mind either ways.

I don't like unnecessary dependencies.  We have too many of them already,
and it basically means that touching any header file triggers a full
kernel rebuild.

If we go down the path of adding unnecessary dependencies, we might as
well do away with make and just script the damn thing, and that'll
probably be faster since there'll be no dependencies to track.  Just
throw everything through ccache and let it deal with anything which
has changed.  Just don't allow your disk to fill up during the build,
ccache really doesn't like that.

-- 
FTTC broadband for 0.8mile line: currently at 9.5Mbps down 400kbps up
according to speedtest.net.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/