linux-kernel - Re: [PATCH v2] i2c: move acpi code back into the core

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 30 Sep 2014 20:46:07 +0200
From:	Jean Delvare <jdelvare@...e.de>
To:	Mika Westerberg <mika.westerberg@...ux.intel.com>
Cc:	Wolfram Sang <wsa@...-dreams.de>, linux-i2c@...r.kernel.org,
	linux-acpi@...r.kernel.org, linux-kernel@...r.kernel.org,
	Lan Tianyu <tianyu.lan@...el.com>
Subject: Re: [PATCH v2] i2c: move acpi code back into the core

On Tue, 30 Sep 2014 19:03:52 +0300, Mika Westerberg wrote:
> On Tue, Sep 30, 2014 at 12:55:20PM +0200, Jean Delvare wrote:
> > The only thing which I find curious is that ACPI_I2C_OPREGION depends
> > on I2C=y. Is this limitation a leftover from when the code was split to
> > a separate file? It builds just fine with I2C=m, and I can't see why it
> > wouldn't work. I have a patch to enable that, I can send it if it is
> > the right thing to do. But maybe I'm missing something?
> 
> I think reason for the limitation is that if there happens to be some
> AML code that is currently using the I2C operation region and the user
> decides to unload the i2c-core.ko module or along those lines.

If that's the reason then shouldn't it be addressed by proper reference
counting instead? We could simply increase the module reference count
when entering the critical section, and decrease it when we're done.

-- 
Jean Delvare
SUSE L3 Support
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/