linux-kernel - RE: [PATCH 2/2] x86: Quark: Comment setup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 1 Oct 2014 06:59:42 +0000
From:	"Ong, Boon Leong" <boon.leong.ong@...el.com>
To:	'Bryan O'Donoghue' <pure.logic@...us-software.ie>
CC:	"x86@...nel.org" <x86@...nel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"tglx@...utronix.de" <tglx@...utronix.de>,
	"mingo@...hat.com" <mingo@...hat.com>,
	"hpa@...or.com" <hpa@...or.com>,
	"davej@...hat.com" <davej@...hat.com>,
	"hmh@....eng.br" <hmh@....eng.br>
Subject: RE: [PATCH 2/2] x86: Quark: Comment setup_arch for TLB/PGE bugfix

> -----Original Message-----
> From: linux-kernel-owner@...r.kernel.org [mailto:linux-kernel-
> owner@...r.kernel.org] On Behalf Of Bryan O'Donoghue
> Sent: Wednesday, October 01, 2014 7:42 AM
> To: tglx@...utronix.de; mingo@...hat.com; hpa@...or.com;
> davej@...hat.com; hmh@....eng.br
> Cc: x86@...nel.org; linux-kernel@...r.kernel.org; Bryan O'Donoghue
> Subject: [PATCH 2/2] x86: Quark: Comment setup_arch for TLB/PGE bugfix
> 
> Quark X1000 requires CR3 to be rewritten to flush TLB entries irrespective of
> the PGE bits in CR4 or PTE.PGE
> 
> Add a comment to setup_arch to indicate that the code
> 
> load_cr3(swapper_pg_dir);
> __flush_tlb_all();
> 
> Will already have flushed the TLB @ the CR3 reload allowing us to skip over a
> potential if/else for Quark.
> 
> This comment clearly states the bug, the behaviour we rely on and the reason
> why we only do it this way - one time.
> 
> Later on cpu_has_pge() will be false due to a fixup in
> intel_init_early() and __flush_tlb_all() will work as expected from that point
> onwards

s/intel_init_early/early_init_intel

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/