lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 07 Oct 2014 18:27:35 +0100 From: Srinivas Kandagatla <srinivas.kandagatla@...aro.org> To: Stephen Boyd <sboyd@...eaurora.org>, Mike Turquette <mturquette@...aro.org> CC: linux-kernel@...r.kernel.org, linux-arm-msm@...r.kernel.org, linux-arm-kernel@...ts.infradead.org, Viresh Kumar <viresh.kumar@...aro.org>, linux-pm@...r.kernel.org Subject: Re: [PATCH v2 04/15] clk: divider: Make generic for usage elsewhere Hi Stephen, Just noticed this regression while testing the patch on Arndale board. https://bugs.linaro.org/show_bug.cgi?id=740 --srini On 03/10/14 19:07, Stephen Boyd wrote: > On 09/05/14 15:47, Stephen Boyd wrote: >> + >> +int divider_get_val(unsigned long rate, unsigned long parent_rate, >> + const struct clk_div_table *table, u8 width, >> + unsigned long flags) >> +{ >> unsigned int div, value; >> - unsigned long flags = 0; >> - u32 val; >> >> div = DIV_ROUND_UP(parent_rate, rate); >> >> - if (!_is_valid_div(divider, div)) >> + if (!_is_valid_div(table, div, flags)) >> return -EINVAL; >> >> - value = _get_val(divider, div); >> + value = _get_val(table, div, flags); >> + >> + min_t(unsigned int, value, div_mask(width)); >> + >> + return 0; > > This should be return value, not return 0. > >> +} >> +EXPORT_SYMBOL_GPL(divider_get_val); >> -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists