linux-kernel - Re: [PATCH v2 02/17] security: make security_file_set_fowner, f_setown and __f

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20141007140225.22301447@synchrony.poochiereds.net>
Date:	Tue, 7 Oct 2014 14:02:25 -0400
From:	Jeff Layton <jeff.layton@...marydata.com>
To:	Dmitry Kasatkin <dmitry.kasatkin@...il.com>
Cc:	Christoph Hellwig <hch@...radead.org>,
	linux-fsdevel@...r.kernel.org, linux-nfs@...r.kernel.org,
	"J. Bruce Fields" <bfields@...ldses.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	linux-security-module <linux-security-module@...r.kernel.org>
Subject: Re: [PATCH v2 02/17] security: make security_file_set_fowner,
 f_setown and __f_setown void return

On Tue, 7 Oct 2014 20:34:57 +0300
Dmitry Kasatkin <dmitry.kasatkin@...il.com> wrote:

> On 7 October 2014 20:17, Christoph Hellwig <hch@...radead.org> wrote:
> > On Tue, Oct 07, 2014 at 08:11:42PM +0300, Dmitry Kasatkin wrote:
> >> If file_set_fowner op is now type of "void", how you can actually
> >> return the value?
> >> I think compiler must give error. How could you compile it?
> >
> > Returning void values is a GNU extension.  I've seen it in a few
> > places in the kernel.  Although in general I'd prefer it we'd remove
> > it (and have the compiler warn about it).
> >
> 
> Cool. There were patches around to use LLVM as well.
> Will it work there?
> 

Well, no one has complained so far, and this has been in linux-next for
more than a month or so. I was just getting ready to send my pull
request to Linus, so you caught this just in time.

I'll respin this patch to not call "return" there and let it stew in
-next for a couple of days before I send the pull request.

Thanks,
-- 
Jeff Layton <jlayton@...marydata.com>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/