linux-kernel - Re: [PATCH 1/2] ARM: dts: vf500/vf610: support VF500 SoC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87r3yid05x.fsf@nbsps.com>
Date:	Wed, 08 Oct 2014 11:57:30 -0400
From:	Bill Pringlemeir <bpringlemeir@...ps.com>
To:	stefan@...er.ch (Stefan Agner)
Cc:	shawn.guo@...escale.com, kernel@...gutronix.de,
	b35083@...escale.com, devicetree@...r.kernel.org,
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] ARM: dts: vf500/vf610: support VF500 SoC

On  2 Oct 2014, stefan at agner.ch wrote:

> Am 2014-10-02 17:28, schrieb Arnd Bergmann:
>> On Thursday 02 October 2014 16:55:23 Stefan Agner wrote:
>>> The VF500 is essentially the same SoC, but with only one core and
>>> without L1 cache. The VF610 is therefore a superset of the VF500.
>>> Move allmost all periperals to vf500.dtsi which is then included
>>> and enhanced by vf610.dtsi.
>>>
>>> Signed-off-by: Stefan Agner <stefan at agner.ch>
>>> ---
>>> Somehow using -M -B switches create a unapplyable patch, hence I
>>> generated one without those options. Sorry about that.
>>>
>>> arch/arm/boot/dts/vf500.dtsi | 498
>>> ++++++++++++++++++++++++++++++++++++++++++
>>> arch/arm/boot/dts/vf610.dtsi | 507
>>> +------------------------------------------
>>> 2 files changed, 510 insertions(+), 495 deletions(-)
>>> create mode 100644 arch/arm/boot/dts/vf500.dtsi

>> I think it would be better to create one extra file that contains the
>> common parts and is included by both vf500 and vf610.

> I also thought about that. But when looking at the product variants,
> its clear that VF500 really contains only features, which are part of
> all other Vybrids (VF3xx series excluded, but these series is not
> really suitable for Linux due to lack of external memory). So
> vf500.dtsi would always be a oneliner (#include <vf.dtsi>).

> Also I disliked this idea because of the somewhat unclear naming
> (vf.dtsi? vfxxx.dtsi?)

Well, I see points from both sides.  I would just like to point out
there maybe more variants than you may think,

 1. With/without security
    Secure parts have a CAAM engine and an SNVS real-time clock.  I
    guess this is the same as the iMX6.
 2. With/without M4 (and some camera features)
    This is the Vf5xx vs VF6xx
 3. With/without L2 cache
    Some VF5xx have the L2
 4. Automotive has an OpenVG engine (plus others differences).

People may not have boards with these features in the mainline.  They
maybe added later.  If Arnd's variant is Linux standard for this, then
it doesn't make sense to special case the Vybrid.  I looked briefly at
the imx6 and 'quad', 'dual-light', etc.  Whatever the current DT
structure is for those, it at least doesn't jump out at me?

It looks like 'imx6sl.dtsi' and 'imx6sl.dtsi' both define the SNVS; yet
I think on some devices these are not present as it is a part option.
The Vybrid is very close SOC to the iMx6.  Note: I looked at the iMx6
for a few minutes.  I am not expert on iMx6 **AND** this is not a
critism, just an example of why Arnd's approach may have some issues.
People making changes for platform VF5xx will be prone to only put
changes in VF5xx and not the 'vf.dtsi'.  The VF6xx is most naturally a
super-set, but even within those parts there are variations.

I think a consistent layout of the includes would be valuable.
Definitely, the repeated information in the DT is bad.  Is there an
unwritten standard?  I think it would be useful to point out an example
that should be the prototype?  Do we have one?  Ie, some SOC family that
we would like as an example?  Or is this case by case?  Or maybe this is
only occurring with Freescale parts; but I doubt that.

Fwiw,
Bill Pringlemeir.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/