linux-kernel - Re: [PATCH 1/2] ARM: dts: vf500/vf610: support VF500 SoC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 02 Oct 2014 17:53:37 +0200
From:	Stefan Agner <stefan@...er.ch>
To:	Arnd Bergmann <arnd@...db.de>
Cc:	shawn.guo@...escale.com, kernel@...gutronix.de,
	b35083@...escale.com, devicetree@...r.kernel.org,
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] ARM: dts: vf500/vf610: support VF500 SoC

Am 2014-10-02 17:28, schrieb Arnd Bergmann:
> On Thursday 02 October 2014 16:55:23 Stefan Agner wrote:
>> The VF500 is essentially the same SoC, but with only one core and
>> without L1 cache. The VF610 is therefore a superset of the VF500.
>> Move allmost all periperals to vf500.dtsi which is then included
>> and enhanced by vf610.dtsi.
>>
>> Signed-off-by: Stefan Agner <stefan@...er.ch>
>> ---
>> Somehow using -M -B switches create a unapplyable patch, hence I
>> generated one without those options. Sorry about that.
>>
>>  arch/arm/boot/dts/vf500.dtsi | 498 ++++++++++++++++++++++++++++++++++++++++++
>>  arch/arm/boot/dts/vf610.dtsi | 507 +------------------------------------------
>>  2 files changed, 510 insertions(+), 495 deletions(-)
>>  create mode 100644 arch/arm/boot/dts/vf500.dtsi
> 
> I think it would be better to create one extra file that contains the common
> parts and is included by both vf500 and vf610.
> 

I also thought about that. But when looking at the product variants, its
clear that VF500 really contains only features, which are part of all
other Vybrids (VF3xx series excluded, but these series is not really
suitable for Linux due to lack of external memory). So vf500.dtsi would
always be a oneliner (#include <vf.dtsi>).

Also I disliked this idea because of the somewhat unclear naming
(vf.dtsi? vfxxx.dtsi?)

--
Stefan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/