linux-kernel - Re: [PATCH 3/3] staging: dgap: introduce dgap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAHb8M2DQQ6hfDDxqcOSX-h6RD3Jp8nqM5bycFOh3sAzX4tiHYA@mail.gmail.com>
Date:	Thu, 9 Oct 2014 10:50:57 +0900
From:	DaeSeok Youn <daeseok.youn@...il.com>
To:	Dan Carpenter <dan.carpenter@...cle.com>
Cc:	Lidza Louina <lidza.louina@...il.com>,
	Mark Hounschell <markh@...pro.net>,
	devel <devel@...verdev.osuosl.org>,
	Greg KH <gregkh@...uxfoundation.org>,
	driverdev-devel@...uxdriverproject.org,
	linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 3/3] staging: dgap: introduce dgap_stop()

Hi, Dan

2014-10-08 20:37 GMT+09:00 Dan Carpenter <dan.carpenter@...cle.com>:
> All three of these patches are good and a nice improvement.  This one is
> a good bugfix.  I have some notes for later, though below.
>
> On Wed, Oct 08, 2014 at 08:13:56PM +0900, Daeseok Youn wrote:
>> diff --git a/drivers/staging/dgap/dgap.c b/drivers/staging/dgap/dgap.c
>> index 7c79fe6..00f34b5 100644
>> --- a/drivers/staging/dgap/dgap.c
>> +++ b/drivers/staging/dgap/dgap.c
>> @@ -71,6 +71,7 @@ MODULE_DESCRIPTION("Driver for the Digi International EPCA PCI based product lin
>>  MODULE_SUPPORTED_DEVICE("dgap");
>>
>>  static int dgap_start(void);
>> +static void dgap_stop(void);
>
> These kinds of forward declarations are annoying.  The whole file needs
> to be re-arranged so that we don't have to deal with them.
OK. I will try to re-arrange and remove forward declarations.

>
>> @@ -561,6 +563,21 @@ failed_class:
>>       return rc;
>>  }
>>
>> +static void dgap_stop(void)
>> +{
>> +     ulong lock_flags;
OK. I will send this patch again after changing ulong to "unsigned long".
>
> This is non-standard.  Traditionally it would be:
>
>         unsigned long flags;
>
> regards,
> dan carpenter

Thanks

regards,
Daeseok Youn
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/