lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Sun, 12 Oct 2014 22:06:01 +0200
From:	Nicolas Ferre <nicolas.ferre@...el.com>
To:	Vinod Koul <vinod.koul@...el.com>, <dmaengine@...r.kernel.org>
CC:	Mark Brown <broonie@...nel.org>, <linux-spi@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 07/12] spi/atmel: use dmaengine_terminate_all() API

On 11/10/2014 17:40, Vinod Koul :
> The drivers should use dmaengine_terminate_all() API instead of
> accessing the device_control which will be deprecated soon
> 
> Signed-off-by: Vinod Koul <vinod.koul@...el.com>

sure:
Acked-by: Nicolas Ferre <nicolas.ferre@...el.com>

Thanks Vinod.

Bye,

> ---
>  drivers/spi/spi-atmel.c |    6 ++----
>  1 files changed, 2 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/spi/spi-atmel.c b/drivers/spi/spi-atmel.c
> index 113c83f..649dcb5 100644
> --- a/drivers/spi/spi-atmel.c
> +++ b/drivers/spi/spi-atmel.c
> @@ -482,11 +482,9 @@ error:
>  static void atmel_spi_stop_dma(struct atmel_spi *as)
>  {
>  	if (as->dma.chan_rx)
> -		as->dma.chan_rx->device->device_control(as->dma.chan_rx,
> -							DMA_TERMINATE_ALL, 0);
> +		dmaengine_terminate_all(as->dma.chan_rx);
>  	if (as->dma.chan_tx)
> -		as->dma.chan_tx->device->device_control(as->dma.chan_tx,
> -							DMA_TERMINATE_ALL, 0);
> +		dmaengine_terminate_all(as->dma.chan_tx);
>  }
>  
>  static void atmel_spi_release_dma(struct atmel_spi *as)
> 


-- 
Nicolas Ferre
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists