linux-kernel - Re: [PATCH 01/12] pata_arasan_cf: use dmaengine_terminate

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 13 Oct 2014 08:17:23 +0530
From:	Viresh Kumar <viresh.kumar@...aro.org>
To:	Vinod Koul <vinod.koul@...el.com>
Cc:	dmaengine@...r.kernel.org, Tejun Heo <tj@...nel.org>,
	"...)" <linux-ide@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 01/12] pata_arasan_cf: use dmaengine_terminate_all() API

On Sat, Oct 11, 2014 at 9:10 PM, Vinod Koul <vinod.koul@...el.com> wrote:
> The drivers should use dmaengine_terminate_all() API instead of accessing
> the device_control which will be deprecated soon
>
> Signed-off-by: Vinod Koul <vinod.koul@...el.com>
> ---
>  drivers/ata/pata_arasan_cf.c |    5 ++---
>  1 files changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/ata/pata_arasan_cf.c b/drivers/ata/pata_arasan_cf.c
> index 4edb1a8..38216b9 100644
> --- a/drivers/ata/pata_arasan_cf.c
> +++ b/drivers/ata/pata_arasan_cf.c
> @@ -420,7 +420,7 @@ dma_xfer(struct arasan_cf_dev *acdev, dma_addr_t src, dma_addr_t dest, u32 len)
>
>         /* Wait for DMA to complete */
>         if (!wait_for_completion_timeout(&acdev->dma_completion, TIMEOUT)) {
> -               chan->device->device_control(chan, DMA_TERMINATE_ALL, 0);
> +               dmaengine_terminate_all(chan);
>                 dev_err(acdev->host->dev, "wait_for_completion_timeout\n");
>                 return -ETIMEDOUT;
>         }
> @@ -928,8 +928,7 @@ static int arasan_cf_suspend(struct device *dev)
>         struct arasan_cf_dev *acdev = host->ports[0]->private_data;
>
>         if (acdev->dma_chan)
> -               acdev->dma_chan->device->device_control(acdev->dma_chan,
> -                               DMA_TERMINATE_ALL, 0);
> +               dmaengine_terminate_all(acdev->dma_chan);
>
>         cf_exit(acdev);
>         return ata_host_suspend(host, PMSG_SUSPEND);

Acked-by: Viresh Kumar <viresh.kumar@...aro.org>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/