linux-kernel - Re: [PATCH] block: update locking context for blk_free

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8738arra1p.fsf@openvz.org>
Date:	Tue, 14 Oct 2014 00:26:10 +0400
From:	Dmitry Monakhov <dmonakhov@...nvz.org>
To:	Jens Axboe <axboe@...com>, linux-kernel@...r.kernel.org
Cc:	keith.busch@...el.com
Subject: Re: [PATCH] block: update locking context for blk_free_devt

Jens Axboe <axboe@...com> writes:

> On 2014-10-13 12:35, Dmitry Monakhov wrote:
>> After 2da78092 this function will not longer sleepy
>>
>> Signed-off-by: Dmitry Monakhov <dmonakhov@...nvz.org>
>> ---
>>   block/genhd.c |    4 +---
>>   1 files changed, 1 insertions(+), 3 deletions(-)
>>
>> diff --git a/block/genhd.c b/block/genhd.c
>> index 09da5e4..ae9aaa5 100644
>> --- a/block/genhd.c
>> +++ b/block/genhd.c
>> @@ -441,12 +441,10 @@ int blk_alloc_devt(struct hd_struct *part, dev_t *devt)
>>    * Free @devt which was allocated using blk_alloc_devt().
>>    *
>>    * CONTEXT:
>> - * Might sleep.
>> + * Don't care.
>>    */
>>   void blk_free_devt(dev_t devt)
>>   {
>> -	might_sleep();
>> -
>>   	if (devt == MKDEV(0, 0))
>>   		return;
>
> What's this against? The might_sleep() was killed about a month ago by 
> commit 46f341ffcfb5. The comment wasn't updated though, it should be.
Against 764f612c6c3c23  linux-block/for-next.
I've found this during development other blockdev related feature.
can you please point what is your development branch.
>
> -- 
> Jens Axboe

Content of type "application/pgp-signature" skipped