linux-kernel - Re: [PATCH] block: update locking context for blk_free

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <543C33B1.2010700@fb.com>
Date:	Mon, 13 Oct 2014 14:18:57 -0600
From:	Jens Axboe <axboe@...com>
To:	Dmitry Monakhov <dmonakhov@...nvz.org>,
	<linux-kernel@...r.kernel.org>
CC:	<keith.busch@...el.com>
Subject: Re: [PATCH] block: update locking context for blk_free_devt

On 2014-10-13 12:35, Dmitry Monakhov wrote:
> After 2da78092 this function will not longer sleepy
>
> Signed-off-by: Dmitry Monakhov <dmonakhov@...nvz.org>
> ---
>   block/genhd.c |    4 +---
>   1 files changed, 1 insertions(+), 3 deletions(-)
>
> diff --git a/block/genhd.c b/block/genhd.c
> index 09da5e4..ae9aaa5 100644
> --- a/block/genhd.c
> +++ b/block/genhd.c
> @@ -441,12 +441,10 @@ int blk_alloc_devt(struct hd_struct *part, dev_t *devt)
>    * Free @devt which was allocated using blk_alloc_devt().
>    *
>    * CONTEXT:
> - * Might sleep.
> + * Don't care.
>    */
>   void blk_free_devt(dev_t devt)
>   {
> -	might_sleep();
> -
>   	if (devt == MKDEV(0, 0))
>   		return;

What's this against? The might_sleep() was killed about a month ago by 
commit 46f341ffcfb5. The comment wasn't updated though, it should be.

-- 
Jens Axboe

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/