lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Tue, 14 Oct 2014 15:47:02 -0300
From:	Ezequiel Garcia <>
To:	Artem Bityutskiy <>
Cc:	Tanya Brokhman <>,,,
	David Woodhouse <>,
	Brian Norris <>,
	Richard Weinberger <>,
	open list <>
Subject: Re: [PATCH v4] mtd: ubi: Extend UBI layer debug/messaging

On 14 Oct 06:09 PM, Artem Bityutskiy wrote:
> On Tue, 2014-10-14 at 11:39 -0300, Ezequiel Garcia wrote:
> > Please use some pr_fmt for this. Something like this before the headers
> > should be enough:
> > 
> > #define pr_fmt(fmt) "UBI: block:" fmt
> Sinc ubiblock is a device, there should be a 'struct device' somewhere,
> so probably dev_printk() and other dev_*() printing functions would be a
> better choice?

A quick code dig shows you should get the struct device associated
to the struct gendisk, with the disk_to_dev() macro.

In other words, something like this should work, provided 'dev' is defined
in the scope as a struct ubiblock:

  #define ubiblock_err(x) dev_err(disk_to_dev(dev->gd), x)

When the gendisk is not available, a simple pr_{} would work.
Ezequiel GarcĂ­a, Free Electrons
Embedded Linux, Kernel and Android Engineering
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to
More majordomo info at
Please read the FAQ at

Powered by blists - more mailing lists