linux-kernel - Re: [PATCH] gcov: add ARM64 to GCOV_PROFILE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20141014144048.e2bf1f5ec23c39d2a59700f6@linux-foundation.org>
Date:	Tue, 14 Oct 2014 14:40:48 -0700
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Peter Oberparleiter <oberpar@...ux.vnet.ibm.com>
Cc:	Riku Voipio <riku.voipio@...aro.org>, linux-kernel@...r.kernel.org,
	linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH] gcov: add ARM64 to GCOV_PROFILE_ALL

On Thu, 09 Oct 2014 16:00:20 +0200 Peter Oberparleiter <oberpar@...ux.vnet.ibm.com> wrote:

> Looks good. Andrew, can you pick this change up via your tree?
> 

Sure.

> 
> On 09.10.2014 12:54, Riku Voipio wrote:
> > Following up the arm testing of gcov, turns out gcov on ARM64
> > works fine as well. Only change needed is adding ARM64 to Kconfig
> > depends.
> > 
> > Tested with qemu and mach-virt
> > 
> > Signed-off-by: Riku Voipio <riku.voipio@...aro.org>
> > ---
> >  kernel/gcov/Kconfig | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/kernel/gcov/Kconfig b/kernel/gcov/Kconfig
> > index cf66c5c..3b74087 100644
> > --- a/kernel/gcov/Kconfig
> > +++ b/kernel/gcov/Kconfig
> > @@ -35,7 +35,7 @@ config GCOV_KERNEL
> >  config GCOV_PROFILE_ALL
> >  	bool "Profile entire Kernel"
> >  	depends on GCOV_KERNEL
> > -	depends on SUPERH || S390 || X86 || PPC || MICROBLAZE || ARM
> > +	depends on SUPERH || S390 || X86 || PPC || MICROBLAZE || ARM || ARM64
> >  	default n
> >  	---help---
> >  	This options activates profiling for the entire kernel.

gcov is doing this the wrong way.  There should be a `select
GCOV_PROFILE_ALL' in each arch/*/Kconfig.

(But pleeeeeeze not at the end of the list!  That's the perfect way of
maximizing patch conflicts, but nobody seems to understand this)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/