linux-kernel - Re: [PATCH] gcov: add ARM64 to GCOV_PROFILE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20141015085434.2c155706@canb.auug.org.au>
Date:	Wed, 15 Oct 2014 08:54:34 +1100
From:	Stephen Rothwell <sfr@...b.auug.org.au>
To:	Andrew Morton <akpm@...ux-foundation.org>
Cc:	Peter Oberparleiter <oberpar@...ux.vnet.ibm.com>,
	Riku Voipio <riku.voipio@...aro.org>,
	linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH] gcov: add ARM64 to GCOV_PROFILE_ALL

Hi Andrew,

On Tue, 14 Oct 2014 14:40:48 -0700 Andrew Morton <akpm@...ux-foundation.org> wrote:
>
> > > diff --git a/kernel/gcov/Kconfig b/kernel/gcov/Kconfig
> > > index cf66c5c..3b74087 100644
> > > --- a/kernel/gcov/Kconfig
> > > +++ b/kernel/gcov/Kconfig
> > > @@ -35,7 +35,7 @@ config GCOV_KERNEL
> > >  config GCOV_PROFILE_ALL
> > >  	bool "Profile entire Kernel"
> > >  	depends on GCOV_KERNEL
> > > -	depends on SUPERH || S390 || X86 || PPC || MICROBLAZE || ARM
> > > +	depends on SUPERH || S390 || X86 || PPC || MICROBLAZE || ARM || ARM64
> > >  	default n
> > >  	---help---
> > >  	This options activates profiling for the entire kernel.
> 
> gcov is doing this the wrong way.  There should be a `select
> GCOV_PROFILE_ALL' in each arch/*/Kconfig.

What they should actually do is select (say) ARCH_HAS_GCOV_PROFILE_ALL
and then GCOV_PROFILE_ALL should depend on that.

-- 
Cheers,
Stephen Rothwell                    sfr@...b.auug.org.au

Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)