linux-kernel - Re: [PATCH] drivers/rtc/interface.c: check the validation of rtc_time in __rtc_read

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20141014152131.1442b937e3010a558c7798a6@linux-foundation.org>
Date:	Tue, 14 Oct 2014 15:21:31 -0700
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Hyogi Gim <ciogenis@...il.com>
Cc:	a.zummo@...ertech.it, john.stultz@...aro.org,
	rtc-linux@...glegroups.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drivers/rtc/interface.c: check the validation of
 rtc_time in __rtc_read_time

On Wed, 8 Oct 2014 11:05:29 +0900 Hyogi Gim <ciogenis@...il.com> wrote:

> Some of rtc devices always return '0' when rtc_class_ops.read_time is called.
> So if rtc_time isn't verified in callback, rtc interface cannot know whether
> rtc_time is valid.

We should fix the buggy .read_time() implementations...

> Check rtc_time by using 'rtc_valid_tm' in '__rtc_read_time'. And add the
> message for debugging.
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/