| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Mon, 13 Oct 2014 18:19:08 -0700 From: Martin Kelly <martin@...tingkelly.com> To: xen-devel@...ts.xenproject.org, x86@...nel.org, linux-kernel@...r.kernel.org Cc: konrad.wilk@...cle.com, boris.ostrovsky@...cle.com, david.vrabel@...rix.com, tglx@...utronix.de, mingo@...hat.com, Martin Kelly <martin@...tingkelly.com>, Martin Kelly <martkell@...zon.com> Subject: [PATCH] xen/setup: add paranoid index check and warning In a call to set_phys_range_identity, i-1 is used without checking that i is non-zero. Although unlikely, a bug in the code before it could cause the value to be 0, leading to erroneous behavior. This patch adds a check against 0 value and a corresponding warning. Signed-off-by: Martin Kelly <martkell@...zon.com> --- arch/x86/xen/setup.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/arch/x86/xen/setup.c b/arch/x86/xen/setup.c index af72161..26e39af 100644 --- a/arch/x86/xen/setup.c +++ b/arch/x86/xen/setup.c @@ -671,7 +671,10 @@ char * __init xen_memory_setup(void) * PFNs above MAX_P2M_PFN are considered identity mapped as * well. */ - set_phys_range_identity(map[i-1].addr / PAGE_SIZE, ~0ul); + if (i > 0) + set_phys_range_identity(map[i-1].addr / PAGE_SIZE, ~0ul); + else + WARN(1, "Something went wrong clamping memory to a factor of EXTRA_MEM_RATIO!"); /* * In domU, the ISA region is normal, usable memory, but we -- 2.1.1 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists