linux-kernel - Re: [PATCH] bcm/CmHost.c: Fix noisy compile warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20141015125934.GB23154@mwanda>
Date:	Wed, 15 Oct 2014 15:59:34 +0300
From:	Dan Carpenter <dan.carpenter@...cle.com>
To:	Jeff Kirsher <jeffrey.t.kirsher@...el.com>
Cc:	devel@...verdev.osuosl.org, gregkh@...uxfoundation.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] bcm/CmHost.c: Fix noisy compile warnings

Or we could fix it but add a multi-line comment with lots of capital
letters and exclamation marks.  I guess we would need to make a function
since this cast is in several places.

void *silence_buggy_casting(u32 pointer)
{
	/*
	 * DANGER! DANGER! DANGER! DANGER! DANGER! DANGER! DANGER!
	 * FIXME!!!  We know this cast is totally buggy.  The BCM driver
	 * doesn't work on 64 bits.  But no one knows how to make this
	 * work.  Oh well.  Let's silence the GCC warning.
	 * DANGER! DANGER! DANGER! DANGER! DANGER! DANGER! DANGER!
	 *
	 */
	return (void *)(long)pointer;
}

Something really ugly and gnarly like that would be hard to ignore.

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/