linux-kernel - Re: [PATCH v3 2/2] usb: dwc2: gadget: modify return statement

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 17 Oct 2014 15:33:25 +0530
From:	Sudip Mukherjee <sudipm.mukherjee@...il.com>
To:	David Laight <David.Laight@...LAB.COM>
Cc:	Paul Zimmerman <paulz@...opsys.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	"linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v3 2/2] usb: dwc2: gadget: modify return statement

On Fri, Oct 17, 2014 at 09:02:00AM +0000, David Laight wrote:
> From: Of Sudip Mukherjee
> > modified the function to have a single return statement at the end
> > instead of multiple return statement in the middle of the function
> > to improve the readability of the code.
> 
> Many of us would disagree with you there.
> Early returns actually make the code easier to read, certainly
> better than a goto 'end of function'.
> 
actually , frankly speaking, this first return statement was also easier for me to understand. But in my v1 patch , Paul mentioned : 
>For a long function like this, I'd rather keep a single return point at
>the end.
so I thought he meant all the return statements in the function. 

thanks
sudip


> 	David
> 
> > This patch depends on the previous patch of the series.
> > 
> > Signed-off-by: Sudip Mukherjee <sudip@...torindia.org>
> > ---
> >  drivers/usb/dwc2/gadget.c | 4 +++-
> >  1 file changed, 3 insertions(+), 1 deletion(-)
> > 
> > diff --git a/drivers/usb/dwc2/gadget.c b/drivers/usb/dwc2/gadget.c
> > index 7f25527..e8a8fc7 100644
> > --- a/drivers/usb/dwc2/gadget.c
> > +++ b/drivers/usb/dwc2/gadget.c
> > @@ -2471,7 +2471,8 @@ static int s3c_hsotg_ep_enable(struct usb_ep *ep,
> >  	dir_in = (desc->bEndpointAddress & USB_ENDPOINT_DIR_MASK) ? 1 : 0;
> >  	if (dir_in != hs_ep->dir_in) {
> >  		dev_err(hsotg->dev, "%s: direction mismatch!\n", __func__);
> > -		return -EINVAL;
> > +		ret = -EINVAL;
> > +		goto error1;
> >  	}
> > 
> >  	mps = usb_endpoint_maxp(desc);
> > @@ -2583,6 +2584,7 @@ static int s3c_hsotg_ep_enable(struct usb_ep *ep,
> > 
> >  error:
> >  	spin_unlock_irqrestore(&hsotg->lock, flags);
> > +error1:
> >  	return ret;
> >  }
> > 
> > --
> > 1.8.1.2
> > 
> > --
> > To unsubscribe from this list: send the line "unsubscribe linux-usb" in
> > the body of a message to majordomo@...r.kernel.org
> > More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/