linux-kernel - Re: [PATCH v2 2/2] Documentation: dmaengine: Add a documentation for the dma controller API

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20141017112356.GO19438@lukather>
Date:	Fri, 17 Oct 2014 13:23:56 +0200
From:	Maxime Ripard <maxime.ripard@...e-electrons.com>
To:	Laurent Pinchart <laurent.pinchart@...asonboard.com>
Cc:	Dan Williams <dan.j.williams@...el.com>,
	Vinod Koul <vinod.koul@...el.com>,
	linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
	dmaengine@...r.kernel.org, Russell King <linux@....linux.org.uk>,
	Arnd Bergmann <arnd@...db.de>,
	Antoine Ténart <antoine@...e-electrons.com>,
	Thomas Petazzoni <thomas@...e-electrons.com>,
	Alexandre Belloni <alexandre.belloni@...e-electrons.com>,
	Boris Brezillon <boris@...e-electrons.com>,
	Matt Porter <matt.porter@...aro.org>,
	Gregory Clement <gregory.clement@...e-electrons.com>,
	Nicolas Ferre <nicolas.ferre@...el.com>
Subject: Re: [PATCH v2 2/2] Documentation: dmaengine: Add a documentation for
 the dma controller API

Hi Laurent,

Just getting back on something...

On Mon, Oct 06, 2014 at 03:09:48PM +0300, Laurent Pinchart wrote:
> > +   * device_prep_dma_*
> > +     - These functions are matching the capabilities you registered
> > +       previously.
> > +     - These functions all take the buffer or the scatterlist relevant
> > +       for the transfer being prepared, and should create a hardware
> > +       descriptor or a list of descriptors from it
> > +     - These functions can be called from an interrupt context
> > +     - Any allocation you might do should be using the GFP_NOWAIT
> > +       flag, in order not to potentially sleep, but without depleting
> > +       the emergency pool either.
> 
> You could add "Drivers should try to preallocate the data structures they 
> require to prepare a transfer."

Isn't that obvious?

I mean, if we're in this function, we're already preparing a
transfer... And I would expect any programmer that followed CS101 to
be able to allocate the memory it needs :)

The rest of the issues have been fixed, thanks!
Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)