linux-kernel - Re: [PATCH] kernel/kmod: fix use-after-free of the sub

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20141017090452.7a413f88@mschwide>
Date:	Fri, 17 Oct 2014 09:04:52 +0200
From:	Martin Schwidefsky <schwidefsky@...ibm.com>
To:	Oleg Nesterov <oleg@...hat.com>
Cc:	Tetsuo Handa <penguin-kernel@...ove.SAKURA.ne.jp>,
	linux-kernel@...r.kernel.org, torvalds@...ux-foundation.org,
	akpm@...ux-foundation.org
Subject: Re: [PATCH] kernel/kmod: fix use-after-free of the
 sub_infostructure

On Thu, 16 Oct 2014 23:58:34 +0200
Oleg Nesterov <oleg@...hat.com> wrote:

> On 10/17, Tetsuo Handa wrote:
> >
> > Ah, I see. Here is a draft of an updated patch.
> 
> Do you mean this part
> 
> 	>  	sub_info->retval = retval;
> 	> +	/* wait_for_helper() will call umh_complete() if UMH_WAIT_PROC. */
> 	> +	if (wait != UMH_WAIT_PROC)
> 	> +		umh_complete(sub_info);
> 	> +	if (!retval)
> 	> +		return 0;
> 	>  	do_exit(0);
> 	>  }
> 
> ?
> 
> Personally I agree, this looks a bit better to me. But this is cosmetic
> and subjective, I leave this to Martin ;)

I don't mind the different code order. As you seem to prefer the above I
use your version.
 
> I also agree that the changelog could mention exec_mmap. Plus a comment
> about UMH_NO_WAIT && sub_info->complete == NULL. So yes, perhaps v2 makes
> sense if Martin agrees.

Ok, this part is a bit tricky and deserves a comment. I'll create one
and send v2.

-- 
blue skies,
   Martin.

"Reality continues to ruin my life." - Calvin.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/