lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:	Fri, 17 Oct 2014 17:57:20 -0700
From:	Doug Anderson <>
To:	Chris <>
Cc:	Heiko Stuebner <>,
	Mike Turquette <>,
	Ian Campbell <>,
	"" <>,
	"" <>,
	Kumar Gala <>,
	Russell King <>,,
	Rob Herring <>,
	Pawel Moll <>,
	Mark Rutland <>,
	Tony Xie <>
Subject: Re: [PATCH v2 2/4] ARM: rockchip: add suspend and resume for RK3288


On Fri, Oct 17, 2014 at 1:47 PM,  <> wrote:
> From: Chris Zhong <>
> It's a basic version of suspend and resume for rockchip, it only support RK3288
> now.
> Signed-off-by: Tony Xie <>
> Signed-off-by: Chris Zhong <>
> ---
> Changes in v2:
> - add the regulator calls in prepare and finish.
> - add the pinmux of gpio6_c6 save and restore

I'm a bit out of time to do a real review right now, but I would have
expected that the pinmux stuff:

* was saved and restored in the pinmux driver.

* was in a separate patch, before this one in the series.

The pinmux driver should have callbacks for saving and restoring
pinmux state, so you should use those.  Maybe exynos_pinctrl_suspend()
is an example, though you only need to save one pin.  You should
probably also explain that only gpio6_c6 needs to be saved and
restored since the MaskROM clobbers it upon resume.

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to
More majordomo info at
Please read the FAQ at

Powered by blists - more mailing lists